Skip to content

fix: Reject async assoc fns of const traits/impls in ast_passes #144907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Reject async assoc fns of const traits/impls in ast_passes #144907

wants to merge 1 commit into from
+73 −10

Conversation

ShoyuVanilla
Copy link
Member

@ShoyuVanilla ShoyuVanilla commented Aug 4, 2025 •
edited by rustbot
Loading

Fixes #117629

@rustbot
Copy link
Collaborator

rustbot commented Aug 4, 2025

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 4, 2025
@ShoyuVanilla ShoyuVanilla marked this pull request as draft August 4, 2025 15:46
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@fmease fmease added the PG-const-traits Project group: Const traits label Aug 4, 2025
@ShoyuVanilla ShoyuVanilla marked this pull request as ready for review August 5, 2025 00:09
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 5, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 5, 2025

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

fmease
fmease approved these changes Aug 5, 2025
View reviewed changes
Copy link
Member

@fmease fmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor nits

@fmease
Copy link
Member

fmease commented Aug 5, 2025 •
edited
Loading

Oh sry, didn't see errs assigned themself. I will wait for them.

@ShoyuVanilla
Copy link
Member Author

Oh sry, didn't see errs assigned themself. I will wait for them.

Thanks for the review anyway. I'll fix the nits!

@compiler-errors
Copy link
Member

@bors r=fmease

@bors
Copy link
Collaborator

bors commented Aug 14, 2025

📌 Commit c700d01 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2025
@fmease fmease changed the title fix: Reject async assoc fns of #[const_trait] in ast_passes fix: Reject async assoc fns of const traits in ast_passes Aug 14, 2025
fmease
fmease requested changes Aug 14, 2025
View reviewed changes
compiler/rustc_ast_passes/src/ast_validation.rs Outdated
Comment on lines 298 to 301
let TraitOrTraitImpl::Trait { constness: Const::Yes(const_trait), .. } = parent else {
return;
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also gonna want to reject async fns inside const trait impls. The following code exhibits the same ICE atm:

#![feature(const_trait_impl)]
const trait Trait { fn f() -> impl Future<Output = ()>; }
impl const Trait for () { async fn f() {} }

Copy link
Member Author

@ShoyuVanilla ShoyuVanilla Aug 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch. I couldn't think of such cases 😅 Thanks!

@fmease
Copy link
Member

fmease commented Aug 14, 2025

My bad, I forgot one thing.

r? fmease @bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 14, 2025
@ShoyuVanilla ShoyuVanilla changed the title fix: Reject async assoc fns of const traits in ast_passes fix: Reject async assoc fns of const traits/impls in ast_passes Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmease fmease fmease requested changes

Assignees

@fmease fmease

Labels
PG-const-traits Project group: Const traits S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ice: const_trait_impl: async functions cannot be const fn
7 participants
@ShoyuVanilla @rustbot @rust-log-analyzer @fmease @compiler-errors @bors @SparrowLii